Lukas Matena
78a3d8b63e
Fixed ASCII folding for non-foldable non-ASCII characters
...
Problem: Add an object, name it using cyrilic, Slice, click Export: the proposed name is mangled. Affects all platforms, 2.2.0 was fine.
Cause: It is mangled during ASCII folding, which was broken with 28c0880 when it was generalized to be used from the fuzzy matcher.
fold_to_ascii(wchar_t c, char *out) relies on narrowing char = wchar_t assignment, the old one used std::back_insert_iterator<std::wstring>.
It is thus unable to leave a character alone even when it should (it should, right?).
Solution:
1. Typed the fold_to_ascii function so it works on wchar_t only, which should mimic the old behaviour.
2. Changed the respective call in fts_fuzzy_match.h. That function also works with wide char C-strings.
Cleanup:
1. Removed the unused fold_utf8_to_ascii(const char *src) overload to avoid code duplication.
2. Untemplated the fold_to_ascii(wchar_t c, std::back_insert_iterator<std::wstring>& out) function, it was never called with a different type.
3. The function is now static in ASCIIFolding.cpp, nobody else needs to know.
2020-12-21 10:31:37 +01:00
..
2020-12-15 10:44:51 +01:00
2020-12-07 18:00:10 +01:00
2020-11-24 16:01:08 +01:00
2020-11-19 19:02:32 +01:00
2020-11-16 17:29:21 +01:00
2020-12-03 12:00:12 +01:00
2020-12-10 13:20:25 +01:00
2020-12-08 12:31:59 +01:00
2020-12-07 19:04:09 +01:00
2020-12-07 14:59:36 +01:00
2020-12-03 12:50:24 +01:00
2020-09-25 10:44:22 +02:00
2020-09-25 10:44:22 +02:00
2020-12-10 08:54:21 +01:00
2020-12-10 08:54:21 +01:00
2020-03-04 10:34:59 +01:00
2020-10-27 14:01:42 +01:00
2020-11-16 08:48:44 +01:00
2020-09-14 18:03:22 +02:00
2020-12-08 13:39:33 +01:00
2020-10-01 20:05:31 +02:00
2020-11-26 14:34:54 +01:00
2020-11-26 10:09:34 +01:00
2020-12-18 15:35:30 +01:00
2020-12-11 15:58:10 +01:00
2020-12-10 15:22:18 +01:00
2020-03-06 15:10:58 +01:00
2020-11-26 14:34:54 +01:00
2020-10-06 12:32:28 +02:00
2020-11-26 14:34:54 +01:00
2020-12-17 16:51:51 +01:00
2020-12-07 16:42:20 +01:00
2020-10-10 14:01:48 +02:00
2020-12-14 12:23:29 +01:00
2020-12-21 10:31:37 +01:00
2020-12-18 09:03:18 +01:00
2020-12-18 09:03:18 +01:00
2020-12-18 11:27:28 +01:00
2020-12-16 16:15:58 +01:00
2020-05-27 08:06:02 +02:00
2020-05-27 08:06:02 +02:00
2020-05-27 14:01:47 +02:00
2020-12-11 12:27:07 +01:00
2020-12-10 13:20:25 +01:00
2020-12-10 13:20:25 +01:00
2020-05-22 16:08:02 +02:00
2020-11-24 11:09:05 +01:00
2020-12-09 11:05:21 +01:00
2020-07-29 15:40:28 +02:00
2020-12-21 10:27:35 +01:00
2020-12-10 11:02:46 +01:00
2020-11-18 10:44:03 +01:00
2020-10-23 07:51:58 +02:00
2020-10-01 20:05:31 +02:00
2020-05-22 15:26:35 +02:00
2020-12-18 11:31:14 +01:00
2020-12-11 13:57:58 +01:00
2020-12-18 13:28:24 +01:00
2020-05-26 13:45:36 +02:00
2020-10-01 20:05:31 +02:00
2020-09-24 15:34:13 +02:00
2020-12-11 14:59:58 +01:00
2020-12-07 10:29:50 +01:00
2020-10-02 09:32:50 +02:00
2020-11-18 13:04:34 +01:00
2020-12-07 16:42:20 +01:00
2020-12-03 11:03:16 +01:00
2020-06-16 17:03:06 +02:00
2020-12-15 12:14:38 +01:00
2020-08-06 13:36:21 +02:00
2020-12-10 08:40:15 +01:00
2020-10-14 08:48:38 +02:00
2020-10-12 15:26:19 +02:00
2020-10-15 09:52:29 +02:00
2020-12-12 09:11:10 +01:00
2020-12-09 14:03:30 +01:00
2020-12-15 12:14:38 +01:00
2020-12-10 11:02:46 +01:00
2020-08-03 19:05:30 +02:00
2020-08-03 19:05:30 +02:00
2020-12-15 14:27:07 +01:00
2020-12-13 19:41:47 +01:00
2020-03-11 09:10:25 +01:00
2020-12-03 12:50:24 +01:00
2020-12-03 11:03:16 +01:00
2020-12-19 09:22:40 +01:00
2020-12-16 17:43:51 +01:00
2020-11-26 14:34:54 +01:00
2020-11-26 14:34:54 +01:00
2020-12-08 17:10:17 +01:00
2020-12-08 17:10:17 +01:00
2020-10-17 13:04:58 +02:00
2020-05-22 16:08:02 +02:00
2020-12-08 17:10:17 +01:00
2020-12-08 17:10:17 +01:00
2020-12-04 13:08:48 +01:00
2020-11-12 15:24:47 +01:00
2020-12-17 11:41:41 +01:00
2020-12-04 15:36:30 +01:00
2020-12-13 21:21:18 +01:00
2020-10-15 10:25:13 +02:00
2020-11-27 14:58:51 -08:00
2020-11-27 14:58:51 -08:00
2020-12-04 13:17:30 +01:00
2020-06-16 17:03:06 +02:00
2020-12-12 11:26:17 +01:00
2020-12-10 11:02:46 +01:00
2020-04-23 18:56:09 +02:00
2020-12-02 12:12:24 +01:00
2020-07-26 21:16:17 +02:00
2020-03-19 16:10:16 +01:00
2020-12-09 13:16:03 +01:00
2020-11-05 11:53:16 -08:00
2020-12-07 16:42:20 +01:00
2020-11-26 14:34:54 +01:00
2020-12-09 06:20:41 +01:00
2020-11-18 13:04:34 +01:00
2020-11-26 14:34:54 +01:00
2020-12-08 17:10:17 +01:00
2020-12-08 17:10:17 +01:00
2020-12-15 14:58:34 +01:00
2020-12-10 11:02:46 +01:00
2020-05-07 20:37:23 +02:00
2020-12-17 09:51:45 +01:00
2020-12-11 13:57:58 +01:00