Lukas Matena
fb7bba2b5a
CMakeLists.txt: turning off -W-ignored-attributes, there are loads of those with newer GCC, originating from Eigen ( https://eigen.tuxfamily.org/bz/show_bug.cgi?id=1221 )
2019-10-17 09:56:38 +02:00
Lukas Matena
605f0ecd54
Revert "CMakeLists.txt: turning off Wno-ignored-attributes on GCC and Clang again"
...
That change breaks compilation on the old buildserver (gcc 5.4). We'll deal with the warning later somehow.
This reverts commit 50448bf4dd .
2019-10-16 12:53:25 +02:00
Lukas Matena
50448bf4dd
CMakeLists.txt: turning off Wno-ignored-attributes on GCC and Clang again
...
Eigen still produces tons of those warnings on newer gcc
2019-10-15 15:10:52 +02:00
Lukas Matena
0dfbfa62df
wxExtensions.cpp: BitmapChoiceRenderer now updates config immediately after its combobox closes
...
This was needed because for some reason, the combobox would not lose focus when mouse left the ObjectList on Linux (KILL_FOCUS forces the update).
The update could be bypassed on Win too by changing extruder and hitting shortcut to reslice.
2019-10-10 11:03:55 +02:00
Lukas Matena
7b45014721
GCode.cpp: Removed a failing assert that was no longer needed
...
The situation it checked happens when the wipe tower is lower than the tallest print object.
The function processes that correctly.
2019-10-10 09:54:27 +02:00
Lukas Matena
59a6318931
Merge branch 'lm_wipe_tower_in_skirt'
2019-10-08 14:13:07 +02:00
Lukas Matena
cf030e8958
Simplified inclusion of the wipe tower into skirt calculation
2019-10-08 14:12:40 +02:00
Lukas Matena
fdf9272fbe
Wipe tower brim width is now part of WipeTowerData class, so it can be used wherever needed
2019-10-08 13:50:51 +02:00
Lukas Matena
9a9c3bac39
Fixup of 47a8b49
2019-10-08 11:05:59 +02:00
Lukas Matena
38d8854a48
Print::validate() - check for empty print has been moved at the beginning of the function
...
This prevents a crash when the print is empty and the wipe tower enabled - validation of the wipe tower attempted to access extruders().front(), which was empty.
No other checks need to be done with the empty print anyway.
2019-10-01 12:48:58 +02:00
Lukas Matena
5ded376fe2
An attempt to fix #2997
...
More fixes might be needed on the other platforms
2019-09-28 09:57:26 +02:00
Lukas Matena
d57a09558e
Several fixes of previous commits related to KDTreeIndirect.hpp and ShortestPath.cpp/.hpp
2019-09-27 13:30:07 +02:00
Lukas Matena
5123673b3a
CMakeLists: filename fix so everything works on case-sensitive filesystems
2019-09-27 11:42:52 +02:00
Lukas Matena
661c91a821
Fixing Linux build
...
GCC 4.8 does not fully support C++11 and in-class char array initialization
2019-09-27 11:31:16 +02:00
Lukas Matena
dbc51a140d
Fixed erroneous use of logical OR where bitwise OR was meant
...
Also, PrintBase::SlicingStatus enum had two entries assigned to 0 - removed the one that was never used
2019-09-25 12:18:30 +02:00
Lukas Matena
1d18339e62
PRUS.cpp: Fixed an always-true condition in extract_model_from_archive
...
SupportMaterial.cpp: Simplified one condition (also solves a -Wmaybe-uninitialized warning on gcc)
2019-09-24 18:09:48 +02:00
Lukas Matena
b67d8c1614
Fixed memsetting non-trivially-copyable types
...
Types stl_stats, stl_normal and SurfaceFillParams should not be zeroed by memset
This is not correct and also triggered warnings on gcc
2019-09-24 17:09:07 +02:00
Lukas Matena
7861fa5086
Whitespace changes to supress misleading indentation warnings
...
These appear in newer gcc when spaces and tabs are mixed
2019-09-24 16:01:01 +02:00
Lukas Matena
c1e3be9b27
MeshUtils.cpp: MeshRaycaster is now aware of the clipping plane
2019-09-24 12:58:12 +02:00
Lukas Matena
656569b0e9
Fix of https://github.com/prusa3d/PrusaSlicer/issues/2953
...
printf-like function argument mismatch: num was long, which was obfuscated by the auto keyword
2019-09-20 16:47:10 +02:00
Lukas Matena
b241ba16ed
Fixed layer profile equality check for wipe tower validation (fixup of b43003d)
2019-09-20 10:53:50 +02:00
Lukas Matena
76a657ce52
Plater.cpp - better added a range-check when selecting filament color in purging volumes dialog
2019-09-18 12:54:21 +02:00
Lukas Matena
741e98804c
Purging volumes dialog now uses filament colour in case extruder color is undefined
2019-09-18 11:47:19 +02:00
Lukas Matena
dd7eb0b186
Merge branch 'lm_raycasting_refactoring' into dev
2019-09-17 14:59:14 +02:00
Lukas Matena
6bcafd7c83
SLA gizmo no more uses IGL code directly, all was moved to the new MeshRaycaster class
2019-09-17 14:57:57 +02:00
Lukas Matena
1dfd8a0e62
MeshRaycaster class is now used in SLA gizmo when selecting by rectangle
2019-09-17 14:57:54 +02:00
Lukas Matena
3694bf3da9
Added functions get_hit_pos, get_hit_normal, ready to implement intersect_ray
2019-09-17 14:57:49 +02:00
Lukas Matena
b6292247e8
Unproject on mesh in the SLA gizmo is now performed by the MeshRaycaster class
2019-09-17 14:57:45 +02:00
Lukas Matena
ee7132a23d
Fixup of 4f89672 + allowing negative support_contact_z
2019-09-13 15:47:00 +02:00
Lukas Matena
2c0b5e6a0a
Merge branch 'lm_clipping_plane_refactoring' into dev
2019-09-13 12:13:22 +02:00
Lukas Matena
70c0c87598
Renamed MeshClipper.cpp/.hpp to MeshUtils.cpp/.hpp
...
More helper classes like the MeshClipper could live here
Moved ClippingPlane class in here to start
2019-09-13 12:03:53 +02:00
Lukas Matena
9782701dd4
Calculating the transformations is now only performed by the MeshClipper
...
Attempted to get mirroring right (that never worked correctly with the clipping plane in the sla gizmo)
The transformation of the support mesh is kind of a mystery to me, hopefully it is right
Also cleaned the code a bit (removed commented-out code, unused variables, etc)
2019-09-13 12:03:53 +02:00
Lukas Matena
546917830b
Initial implementation of MeshClipper class
...
So far the work is shared between the old code in GLGizmoSlaSupports.cpp and the new class
2019-09-13 12:03:53 +02:00
Lukas Matena
cf23146ee3
Refactoring the SLA clipping plane
...
The plane is now internally stored as a plane in world coordinates
2019-09-13 12:03:53 +02:00
Lukas Matena
2fef16c39a
Fix of #1266 and #2258
...
In case there were empty object layers supposed to be floating on supports which were set to use a specific extruder, wipe tower was missing layer required to do the toolchange, leading to a crash
Such cases are now detected and layers that need it are additionally assigned as wipe tower layers
Also tracked as SPE-526
2019-09-10 13:13:21 +02:00
Lukas Matena
4fc20090c8
GUI_ObjectList.cpp: Max layer height defaults to 0.75*nozzle_diameter as it should ( #2892 )
2019-09-10 12:34:03 +02:00
Lukas Matena
c5f78dd6e2
Some more warnings fixed (WipeTower.cpp/.hpp)
2019-09-10 12:08:43 +02:00
Lukas Matena
86b258f727
Fixed many warnings in following files:
...
src/slic3r/Config/Snapshot.cpp
src/slic3r/GUI/Field.cpp
src/slic3r/GUI/GLToolbar.cpp
src/slic3r/GUI/GUI_ObjectList.cpp
src/slic3r/GUI/GUI_ObjectList.hpp
src/slic3r/GUI/Plater.cpp
src/slic3r/GUI/Plater.hpp
src/slic3r/GUI/PresetBundle.cpp
src/slic3r/GUI/Tab.cpp
src/slic3r/GUI/wxExtensions.cpp
2019-09-10 12:08:43 +02:00
Lukas Matena
a62bba2508
CoolingBuffer.cpp: Fixed a crash when encountering an invalid toolchange
...
This can happen if the user enters invalid toolchange through the custom gcodes
Such toolchange is now simply ignored by the CoolingBuffer, exporting gcode is NOT stopped, a log error is emitted
2019-09-10 11:46:18 +02:00
Lukas Matena
4dbc8b22a5
Updated tooltip
2019-09-09 16:39:26 +02:00
Lukas Matena
97a02f4412
Merge branch 'lm_custom_toolchange'
2019-09-09 16:12:09 +02:00
Lukas Matena
822bc7a91c
Fix of previous commit, tooltip update
2019-09-09 16:02:39 +02:00
Lukas Matena
499fdeddd1
Custom toolchange gcode is searched for tool-changing command
...
If the custom toolchange gcode switches extruder to the one that is expected, PrusaSlicer does not issue its own T command
Otherwise, this command is inserted just after the custom gcode, even in case it is not empty
This should prevent issues such as #2884 and #2886 from being reported
2019-09-09 13:05:18 +02:00
Lukas Matena
a985a2720f
Fixed some more warnings, moved function to get ExtrusionRole name into ExtrusionEntity.hpp
...
So it can be called from wherever it may be needed
2019-09-06 15:55:07 +02:00
Lukas Matena
3f988b314c
Fixed several warnings (Config.hpp and few other files)
2019-09-06 15:55:07 +02:00
Lukas Matena
6cc29c308c
Fill.cpp: Fixed a typo
2019-09-05 16:03:44 +02:00
Lukas Matena
09e4ac42ba
Fixed some more warnings (mostly GLGizmoSlaSupports.cpp)
2019-09-04 16:05:32 +02:00
Lukas Matena
570bec299f
Merge branch 'master' into dev
2019-09-04 15:50:18 +02:00
Lukas Matena
326eb5e343
GUI_ObjectList.cpp: Fixed a crash when deleting instances.
...
Deleting second-but-last instance deletes the whole Instances node, we must select object node in that case.
2019-09-04 15:15:35 +02:00
Lukas Matena
805a5d22a1
Fixed couple of warnings in WipeTower.cpp, ToolOrdering.cpp and GCode.cpp
2019-09-04 14:56:35 +02:00
Lukas Matena
fd47891793
GLGizmoSlaSupports.cpp: Snapshot label now differs for turning the gizmo on/off
...
This behaviour was broken by recent merge
2019-09-03 10:16:06 +02:00
Lukas Matena
b89d9c7aff
Merge branch 'lm_gizmomanagerrefactoring' into dev
2019-09-03 08:29:31 +02:00
Lukas Matena
66d74bc591
Merge branch 'lm_layer_height_validation' into dev
2019-09-02 16:31:59 +02:00
Lukas Matena
7d54b04699
Merge branch 'lm_wiping_dialog_colors' into dev
2019-09-02 16:31:22 +02:00
Lukas Matena
9ac6909d30
Fixed couple of warnings in GUI_ObjectList.cpp and GUI_ObjectSettings.cpp
2019-09-02 16:27:48 +02:00
Lukas Matena
942f959e87
Fixed couple of warnings
...
Turned several includes into forward declarations
Removed several sprintf calls in favor of std::to_string
2019-09-02 16:27:48 +02:00
Lukas Matena
19ab746a38
Merge branch 'master' into lm_gizmomanagerrefactoring
2019-09-02 14:31:03 +02:00
Lukas Matena
d8a274c5ab
Nearly finished refactoring of GLGizmoManager
2019-09-02 14:30:15 +02:00
Lukas Matena
409a7c7734
SLA gizmo open/close should be saved on undo/redo stack
2019-09-02 14:30:15 +02:00
Lukas Matena
b6d35c9840
Started an attempt to refactor GLGizmoManager
2019-09-02 14:30:12 +02:00
Lukas Matena
b43003dfad
Fixed layer height equality check needed in order to enable the wipe tower
...
The change was needed because enabling the new layer-height-modifier made the validation fail, even if there was no real layer height modification
2019-08-29 16:13:04 +02:00
Lukas Matena
350b7cbe04
Fixed out-of-bounds access when adding a colorchange before the first layer
...
Fixed several signedness related warnings
2019-08-29 12:03:42 +02:00
Lukas Matena
af2a3d2c08
Fixes of the wipe tower
...
- added an extra travel move after a toolchange
- wipe tower only sets temperatures with single extruder MM printers
- ooze prevention does not work with the wipe tower - added a check into Print::validate()
2019-08-28 16:28:22 +02:00
Lukas Matena
4992b8f749
ConfigManipulation.cpp: Fixed couple of memory leaks due to heap-allocated wxMessageDialogs that were never freed
2019-08-27 13:27:11 +02:00
Lukas Matena
42c5c19f1c
GCodeWriter.cpp: Fixed skipped z-lifts when its height was equal to layer height ( https://github.com/prusa3d/PrusaSlicer/issues/2154 )
2019-08-27 12:41:00 +02:00
Lukas Matena
3addae3bb4
GCode.cpp: Avoid crossing perimeters performance optimization
2019-08-23 13:06:29 +02:00
Lukas Matena
1d8e060b75
Followup of previous commits - removing some unnecessary code
2019-08-23 12:11:45 +02:00
Lukas Matena
bf232e1ade
Fixed forward declaration of struct Slic3r::UndoRedo::Snapshot so MSVC does not complain
2019-08-23 10:34:16 +02:00
Lukas Matena
52933d1bab
Recalculate SLA supports after undo/redo in case SLA gizmo was active and had supports when the snapshot was taken
2019-08-23 01:42:59 +02:00
Lukas Matena
b55a140ad4
SLA gizmo takes snapshots on opening and closing
2019-08-23 01:42:59 +02:00
Lukas Matena
c736b657d4
SLA gizmo now refuses to close with unsaved changes in editing mode
2019-08-23 01:42:59 +02:00
Lukas Matena
24b9c926c6
GLGizmoManager.cpp: Initial work on the possibility of a gizmo refusing to close
2019-08-23 01:42:59 +02:00
Lukas Matena
e928c0ac0b
Added a missing include
2019-08-22 11:35:25 +02:00
Lukas Matena
6a22651501
Fixed a typo preventing compilation on Linux
2019-08-20 20:24:37 +02:00
Lukas Matena
53939796a6
GCode.cpp: Fix of temperature change before print
...
Function set_extruder can be called before moving to the first layer, m_layer_index is then -1. We definitely don't want to set temperature for second layer in that case.
2019-08-20 14:22:31 +02:00
Lukas Matena
92bdb68e11
Extended the error message when empty layers are detected
2019-08-19 15:50:49 +02:00
Lukas Matena
a66c59941d
Better error message in case of corrupted PrusaSlicer.ini
2019-08-19 12:55:57 +02:00
Lukas Matena
0f32223ba0
WipeTower: linear advance is disabled immediately before ramming, not before moving to the wipe tower
...
Linear advance is reset by filament start gcode after a toolchange. However, not all moves to the wipe tower
end with a toolchange (brim, empty grid) and it would therefore disable linear advance until the next toolchange
This should solve https://github.com/prusa3d/PrusaSlicer/issues/2770
2019-08-16 00:20:51 +02:00
Lukas Matena
c8ac46df43
Fixed some memory leaks related to heap-allocated wxDialogs
...
Some correctly destroyed dialogs were also converted to stack-allocated
2019-08-15 12:52:56 +02:00
Lukas Matena
4cca6f8724
Allowed the skirt to intersect brim ( https://github.com/prusa3d/PrusaSlicer/issues/724 )
...
Brim lines are split at the intersection so there is no overextrusion.
2019-08-15 12:27:49 +02:00
Lukas Matena
15744f021a
Print::validate: added epsilon checks on nozzle and filament diameter validation ( https://github.com/prusa3d/PrusaSlicer/issues/2737 )
...
Changed messagebox text after changing extruder diameter with single extruder printers so it is more obvious why it shows
In case nozzle diameters differ and someone checks 'single_extruder_mm', PrusaSlicer asks whether all diameters should be unified. Answering NO did not undo the SEMM check. It does now.
2019-08-15 10:43:17 +02:00
Lukas Matena
c84b1ca34b
Multimaterial initial priming for non-Prusa printers ( https://github.com/prusa3d/PrusaSlicer/issues/1121 )
...
The initial priming now does not assume anything about bed width and always uses the space it has
In case of circular beds it places the priming lines along the diameter
Custom beds are not supported (they are treated as circular with no extra checks whether it is sane)
Slight refactoring of the WipeTower class (constructor now gets reference to PrintConfig and not the individual values, same with set_extruder). This was legacy from times when the wipe tower was meant to be abstract and independent on the rest)
2019-08-15 01:41:46 +02:00
Lukas Matena
c189140221
Fixed a false positive empty layer report
...
Reported in https://github.com/prusa3d/PrusaSlicer/issues/2752 and was a result of setting support contact z distance to negative value.
This lowered the maximum allowed print_z of the next layer, even though previous layer had object layers too, so the penalty from the contact z should not have been applied.
Fixed simply by rejecting the negative contact_z.
2019-08-13 11:02:58 +02:00
Lukas Matena
1b5d561b7c
Added handling of std::bad_alloc so the user gets more comprehensible error message
...
Call to boost::nowide::nowide_filesystem() was made Windows only
2019-08-08 16:55:25 +02:00
Lukas Matena
1789179506
GLGizmoSlaSupports.cpp: unproject_on_mesh does not throw exceptions but uses bool return value to signal success
2019-08-07 16:17:41 +02:00
Lukas Matena
8e4f777bd3
One more fix on the empty layers detection - support contact z distance is taken into account
...
If it wasn't, anything with raft would be rejected unless contact z was zero. We do not want that.
2019-08-07 12:02:30 +02:00
Lukas Matena
f61c982111
GCode.cpp: fixed detection of empty layers so it doesn't give false positives
...
That could happen on empty support layers which do not necessarily matter, since their spacing is not generally synchronized with the object
The new hopefully correct logic is "if there are extrusions on a layer, check that last layer with extrusions is at most the new layer height below
This is a fixup of changes from 0de6e53 and 6ab1cec
2019-08-07 10:54:36 +02:00
Lukas Matena
b0d4cb6e06
Memory usage is now shown in SysInfoDialog on all three platforms
2019-08-05 20:17:29 +02:00
Lukas Matena
6da196b419
Corrected return value of ConfigOptionVector::apply_override to what was intended (this didn't cause any bug though, the return value is currently not used)
2019-08-05 15:24:49 +02:00
Lukas Matena
3efae8a03e
Added a memory logging function for Mac and Linux
2019-08-05 13:39:03 +02:00
Lukas Matena
0de6e53219
Followup of 6ab1cec - empty layers are ok if there are only other empty layers on top of them
...
Also fixed a possible crash in Print.cpp when preparing the wipe tower layers
2019-08-04 22:57:59 +02:00
Lukas Matena
6ab1cec48c
Empty layers detection added to GCode.cpp
...
Added detection of empty layers so the wipe tower doesn't trip on them (it is not printable anyway).
This should improve wipe tower reliability with supports, objects standing on edges, etc.
I also turned an assert into exception throw to prevent hard crashes and nonsense output.
2019-08-02 16:54:18 +02:00
Lukas Matena
170bd8b064
Wipetower fix: temperature-changing command was sometimes missing after the toolchange
...
Cause: variable holding last issued temperature was not reset where it should have been
This should fix issue #2685
2019-08-01 15:31:02 +02:00
Lukas Matena
98e08e356f
Changed snapshot names for reset scale/reset rotation/drop to bed functions (it's done a bit simpler this time)
2019-08-01 12:41:31 +02:00
Lukas Matena
81ab43ea9a
Revert "Changed snapshot names for reset rotation/reset scale/drop to bed functions"
...
This reverts commit 1ca8ff1285 .
2019-08-01 12:23:39 +02:00
Lukas Matena
1ca8ff1285
Changed snapshot names for reset rotation/reset scale/drop to bed functions
2019-08-01 10:58:52 +02:00
Lukas Matena
aeb29b1184
SLA points on all objects are assigned Generating status before the background processing starts
2019-07-31 13:00:35 +02:00
Lukas Matena
599f2e07db
Config parameters accessible from SLA gizmo are now saved on the undo/redo stack
2019-07-31 12:40:47 +02:00
Lukas Matena
ab0d1af3ca
Fixed a problem with deleting button in SLA gizmo
2019-07-31 10:33:03 +02:00
Lukas Matena
99f34f8321
SLA gizmo: fixed a crash with multiple selection
2019-07-31 10:18:49 +02:00